fix(vector): warp groups using combined bounding box#3554
Open
LilSuperUser wants to merge 2 commits intoGraphiteEditor:masterfrom
Open
fix(vector): warp groups using combined bounding box#3554LilSuperUser wants to merge 2 commits intoGraphiteEditor:masterfrom
LilSuperUser wants to merge 2 commits intoGraphiteEditor:masterfrom
Conversation
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
Ayush2k02
suggested changes
Feb 11, 2026
| @@ -817,20 +832,22 @@ async fn box_warp(_: impl Ctx, content: Table<Vector>, #[expose] rectangle: Tabl | |||
| DVec2::new(source_bbox[0].x, source_bbox[1].y), | |||
| ] | |||
| }; | |||
Contributor
There was a problem hiding this comment.
NIT: add this line back in
Ayush2k02
suggested changes
Feb 11, 2026
Ayush2k02
reviewed
Feb 11, 2026
LilSuperUser
force-pushed
the
fix/3551/box-warp-group-bbox
branch
from
c369737 to
e2e2114
Compare
Groups of paths now warp together as a unit instead of independently. - union all subpath bounding boxes into one frame - normalize points and handles against shared bounds - apply bilinear interpolation into target quad - reset transforms after warp Fixes GraphiteEditor#3551
- move normalization epsilon to a file-level constant - use Rect::combine_bounds for bbox merging (wrapping [DVec2; 2]) - restore blank line after dst_corners block - restore and align inline comments across point and handle transforms
LilSuperUser
force-pushed
the
fix/3551/box-warp-group-bbox
branch
from
e2e2114 to
90b3f13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups of paths now warp together as a unit instead of independently.
Closes #3551